Add enum for MetaTag properties and names outlined in #348.
#373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twostraws
reviewed
Jan 27, 2025
| } | ||
|
|
||
| /// Metadata properties for social media sharing. | ||
| public enum Property: String, Sendable { |
There was a problem hiding this comment.
The distinction between Name and Property seems like a bagatelle, and means folks need to select the correct initializer in order to see code completion for the things they care about. Could we merge all these into a single enum, then use a computed property to return the key string based on a switch?
There was a problem hiding this comment.
Excellent idea! Will revise 🙌🏼
MrSkwiggs
reviewed
Jan 27, 2025
Comment on lines
13
to
34
| /// Metadata names for social media cards. | ||
| public enum Name: String, Sendable { | ||
| /// The image to display in Twitter cards. | ||
| case twitterImage = "twitter:image" | ||
| /// The title to display in Twitter cards. | ||
| case twitterTitle = "twitter:title" | ||
| /// The domain to display in Twitter cards. | ||
| case twitterDomain = "twitter:domain" | ||
| /// The type of Twitter card to use. | ||
| case twitterCard = "twitter:card" | ||
| /// Whether to disable Twitter tracking. | ||
| case twitterDoNotTrack = "twitter:dnt" | ||
| /// The description to display in Twitter cards. | ||
| case twitterDescription = "twitter:description" | ||
| /// The software used to generate the document. | ||
| case generator | ||
| /// The viewport configuration for responsive web design. | ||
| case viewport | ||
|
|
||
| /// The meta attribute key. | ||
| var key: String { "name" } | ||
| } |
There was a problem hiding this comment.
I see the introduction of some more public-facing enums and decided to create #380. I'd like to have a conversation there to decide whether or not this is something we want to do instead
|
Perfect – thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.