Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused and undocumented mackup command #1458

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Conversation

twpayne
Copy link
Owner

@twpayne twpayne commented Sep 24, 2021

Fixes #885.

@twpayne twpayne changed the title feat: Remove unused and undocumented mackup command chore: Remove unused and undocumented mackup command Sep 24, 2021
@nkgm
Copy link

nkgm commented Dec 7, 2021

Really wish I'd come across this a couple of months earlier. Would this still work if merged in the current version?

@twpayne
Copy link
Owner Author

twpayne commented Dec 7, 2021

Yes, this would work. However, do consider:

  1. The mackup developers are unresponsive and do not seem keen to collaborate.
  2. The mackup data quality is OK but not brilliant. It's not complete for a number of applications.

@nkgm
Copy link

nkgm commented Dec 7, 2021

Those are fair points. I guess it's easy enough adding the files manually, though I do wish we had file completion on chezmoi re-add with just the modified files (or simply the files chezmoi is already managing) as these app config file paths are easy to forget.

Thanks for your work on chezmoi btw. It's hard to imagine how I've managed without it for so long :)

@twpayne
Copy link
Owner Author

twpayne commented Dec 7, 2021

Thank you for your kind words!

I do wish we had file completion on chezmoi re-add with just the modified files (or simply the files chezmoi is already managing) as these app config file paths are easy to forget.

This is a great suggestion, although it might be a little tricky to implement. Could you please open a new issue to track this?

@twpayne twpayne mentioned this pull request Dec 15, 2021
@eugenesvk
Copy link
Contributor

I've also just become aware of the mackup project and its app database, and it seems like a great idea (even though it's a bit late for me as I've had to muck ;) through those apps' config files manually to pick the ones that should be synced via chezmoi)

I know you mentioned

It seems that nobody else needs or wants the feature

but maybe a big part of that is that "nobody" was aware of its existence? Maybe this could be restored to some documented experimental command to allow for people to know about it and see if incorporating it into their workflows improves config management?

@twpayne
Copy link
Owner Author

twpayne commented Jul 10, 2023

The other problems are:

  • The mackup developers are unresponsive and do not seem keen to collaborate.
  • The mackup data quality is OK but not brilliant. It's not complete for a number of applications.

Overall, I don't think that mackup really adds that much. If enough (say five) different people chime in here to say they want this feature restored, then I would consider reverting this PR.

@eugenesvk
Copy link
Contributor

Would you then kindly reopen #885 so that at least this issue is a bit more visible so people could chime in (fwiw it already had 4 👍 before it got locked)

The mackup developers are unresponsive and do not seem keen to collaborate

That's unfortunate, chezmoi is a great and powerful tool to collaborate with :)!

The mackup data quality is OK but not brilliant. It's not complete for a number of applications

That's still better than the baseline of having to manually pick specific config files in a sea of caches and data files and what not?

@twpayne
Copy link
Owner Author

twpayne commented Jul 10, 2023

Would you then kindly reopen #885 so that at least this issue is a bit more visible so people could chime in (fwiw it already had 4 👍 before it got locked)

Done. Note that, despite the 4 👍 s, and a direct request, no one tested the feature.

@eugenesvk
Copy link
Contributor

Thank you, but the issue can't be voted on since it's "This conversation has been locked as resolved and limited to collaborators."

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pre-defined templates for config files of popular applications
3 participants