-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove unused and undocumented mackup command #1458
Conversation
8d96d87
to
7ad9a7b
Compare
Really wish I'd come across this a couple of months earlier. Would this still work if merged in the current version? |
Yes, this would work. However, do consider:
|
Those are fair points. I guess it's easy enough adding the files manually, though I do wish we had file completion on Thanks for your work on chezmoi btw. It's hard to imagine how I've managed without it for so long :) |
Thank you for your kind words!
This is a great suggestion, although it might be a little tricky to implement. Could you please open a new issue to track this? |
I've also just become aware of the mackup project and its app database, and it seems like a great idea (even though it's a bit late for me as I've had to muck ;) through those apps' config files manually to pick the ones that should be synced via chezmoi) I know you mentioned
but maybe a big part of that is that "nobody" was aware of its existence? Maybe this could be restored to some documented experimental command to allow for people to know about it and see if incorporating it into their workflows improves config management? |
The other problems are:
Overall, I don't think that mackup really adds that much. If enough (say five) different people chime in here to say they want this feature restored, then I would consider reverting this PR. |
Would you then kindly reopen #885 so that at least this issue is a bit more visible so people could chime in (fwiw it already had 4 👍 before it got locked)
That's unfortunate, chezmoi is a great and powerful tool to collaborate with :)!
That's still better than the baseline of having to manually pick specific config files in a sea of caches and data files and what not? |
Done. Note that, despite the 4 👍 s, and a direct request, no one tested the feature. |
Thank you, but the issue can't be voted on since it's "This conversation has been locked as resolved and limited to collaborators." |
Fixes #885.