Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements and Fixes for go-gpx #20

Closed
wants to merge 11 commits into from
Closed

Conversation

inode64
Copy link
Contributor

@inode64 inode64 commented May 28, 2023

Title: Improvements and Fixes for go-gpx

Description:

This pull request includes a set of changes aimed at improving the functionality and handling of the go-gpx library:

  • Included support for Garmin schemas.
  • Fixed issue regarding the definition of email.
  • Made extensions optional.
  • Attached are more significant tracks for testing.
  • Added support for GPX 1.0 management due to missing tags like name, description, author, email, and others.
  • Modified the GPX structure, given an issue in GO not correctly managing XML namespaces prefixes. Initially, this problem drove me crazy, so I even created a sample to make it easier to visualize: https://go.dev/play/p/0M_tCWNJ-0w. Here is the solution to the problem: https://go.dev/play/p/4MpYbo33-gc. There's an open ticket regarding this issue at encoding/xml: support for XML namespace prefixes golang/go#9519.
  • Hence, I've removed the use of XMLAttrs and have searched for all Garmin extensions amongst my 2000 tracks. These have also been useful to ensure that no information is lost when using this library.
  • I've had to change the date format from time.Time to string as it occasionally wasn't present.

These modifications should improve the overall functionality and reliability of the go-gpx library, especially regarding the management of Garmin schemas and GPX 1.0.

@twpayne
Copy link
Owner

twpayne commented Jun 4, 2023

Thank you for your work here. This is a very large PR that will take some time for me to understand. In the future, please can you follow Dave Cheney's talk, then code approach.

@inode64
Copy link
Contributor Author

inode64 commented Jun 5, 2023

okay,
I have tried to separate the improvements and bugs in different commits
If you want, create different pull requests for each change.

@twpayne
Copy link
Owner

twpayne commented Jul 11, 2023

Please can you separate this into multiple PRs, with each PR addressing one aspect.

@twpayne
Copy link
Owner

twpayne commented Oct 26, 2024

Gentle ping. I'm keen to see these contributions in go-gpx.

@twpayne twpayne closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants