Adding Deployment Annotations #106
Conversation
There was a problem hiding this comment.
@ChevronTango This looks good to me.
@vyas-n What do you think?
|
@ChevronTango Could you recommit these changes with signed commits? This comment has some resources to help with that if you need it: #93 (comment) |
|
Looks good to me, just needs signed commits before it can be merged 👍🏽 |
|
Just pushed up a signed commit using Sigstore, however GitHub doesn't formally support those signatures yet, despite them being valid and secure. Hopefully that doesn't prevent the merge going ahead. If it does I'll resign using a GPG key. |
|
@ChevronTango Unfortunately GitHub is still saying that the commits need to be signed. Could you go ahead and commit them again with GPG/SSH? |
Signed-off-by: Edward Brough <edward.brough@gmail.com>
|
@joshsizer that should be all ready to go now |
Thank you! |
Closes #86
This adds the ability for users to specify annotations on the deployment.