Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Implement ReadParams #304

Merged
merged 11 commits into from
Aug 13, 2024

Conversation

gonzalezzfelipe
Copy link
Contributor

@gonzalezzfelipe gonzalezzfelipe commented Jul 17, 2024

Depends on: utxorpc/spec#116

@gonzalezzfelipe gonzalezzfelipe marked this pull request as ready for review July 23, 2024 20:24
@scarmuega
Copy link
Member

@gonzalezzfelipe looks very good! The only thing I'm concerned is the hack to handle the Shelley params update on preview, I'm worried of introducing tech-debt.

I think that the correct approach would be to understand which era should be used to initialize the pparams by looking at the genesis files. Not sure what, but there should be something in the configs that flags Shelley as the initial protocol version for preview.

@gonzalezzfelipe
Copy link
Contributor Author

@gonzalezzfelipe looks very good! The only thing I'm concerned is the hack to handle the Shelley params update on preview, I'm worried of introducing tech-debt.

I think that the correct approach would be to understand which era should be used to initialize the pparams by looking at the genesis files. Not sure what, but there should be something in the configs that flags Shelley as the initial protocol version for preview.

I tried another aproach, bootstrapping the Shelley params when the initial update doesn't correspond to a Byron era update instead of going with the genesis files because I couldn't find a way to deduce it from there (other than using the network magic and hardcoding that Preview should begin from Shelley)

@scarmuega scarmuega merged commit 1cd72d6 into txpipe:main Aug 13, 2024
6 checks passed
@gonzalezzfelipe gonzalezzfelipe deleted the chore/implement_read_params branch August 13, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants