Add max_slots_before_prune config #409
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinSchere
commented
Dec 24, 2024
| @@ -238,7 +239,10 @@ pub fn apply_block_batch<'a>( | |||
| .map(|x| x.0) | |||
| .unwrap(); | |||
|
|
|||
| let to_finalize = lastest_immutable_slot(tip, byron, shelley); | |||
| let to_finalize = max_slots_before_prune | |||
| .map(|x| tip - x) | |||
There was a problem hiding this comment.
@scarmuega I'm not sure if you want extra guardrails here in case the user shoots themselves in the foot by setting max_slots_before_prune to a very small number.
scarmuega
force-pushed
the
main
branch
2 times, most recently
from
0c606cf to
3b3de10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new config called
max_slots_before_prunewhich allows the user to configure the oldest age of the slot kept in the ledger.This is useful if the data in the ledger is required for use cases other than syncing the chain, such as indexers.