add cbor decoder for HardForkQuery #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd `ledgerquery` adds the `encode` and `decode` implementations for the `hardforkquery` and `ledgerquery` structs, located in the `pallas-network/src/miniprotocols/localstate/queries_v16/codec.rs` and `pallas-network/src/miniprotocols/localstate/queries_v16/mod.rs` files respectively.
falcucci
changed the title
hardforkquery and ledgerqueryupdates the hardforkquery codec, making the `_` case return an error instead of unreachable. this change allows for better error handling in the event of an invalid tag.
```diff
diff --git a/pallas-network/src/miniprotocols/localstate/queries_v16/codec.rs b/pallas-network/src/miniprotocols/localstate/queries_v16/codec.rs
index 7abe225e4e8e..2e518b685e69 100644
--- a/pallas-network/src/miniprotocols/localstate/queries_v16/codec.rs
+++ b/pallas-network/src/miniprotocols/localstate/queries_v16/codec.rs
@@ -178,7 +178,7 @@ impl<'b> decode<'b, ()> for hardforkquery {
match tag {
0 => ok(self::getinterpreter),
1 => ok(self::getcurrentera),
- _ => unreachable!(),
+ _ => err(decode::error::message("invalid tag")),
}
}
}
```
falcucci
changed the title
scarmuega
reviewed
Nov 17, 2023
8 tasks
falcucci
changed the title
falcucci
force-pushed
the
test/add-epoch-no
branch
from
9e0486c
to
447fb33
Compare
scarmuega
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
those were missing to make the localstate query test fixtures.