getSlotMenuOptions.apply incorrectly applying arguments when right clicking on slots.

[Trung0246]

ComfyUI-Dev-Utils/web/reroute.js

Line 13 in 3f66a0b

menuInfo = getSlotMenuOptions.apply(this, slot);

I think it should be something like this:

menuInfo = getSlotMenuOptions.apply(this, [slot]);

[ty0x2333]

The line of code

menuInfo = getSlotMenuOptions.apply(this, slot); 

is fine.

Below is the location of the relevant code in litegraph.js:

jagenjo/litegraph.js - litegraph.d.ts

getSlotMenuOptions?(slot: INodeSlot): ContextMenuItem[];

Interface INodeSlot

export interface INodeSlot {
    name: string;
    type: string | -1;
    label?: string;
    dir?:
        | typeof LiteGraph.UP
        | typeof LiteGraph.RIGHT
        | typeof LiteGraph.DOWN
        | typeof LiteGraph.LEFT;
    color_on?: string;
    color_off?: string;
    shape?: SlotShape;
    locked?: boolean;
    nameLocked?: boolean;
}

@Trung0246

[Trung0246]

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/apply

I think you probably misunderstood. On recent update, right clicking on input/output slot will cause error when running that line of code, which will no longer shows the actual right click menu. Other node pack I saw where either using apply(this, [slot]) or call(this, ...slot).

Alternative approach is getSlotMenuOptions.call(this, ...slot); if you thinks using apply is undesirable.

[Trung0246]

@ty0x2333 the web console should shows the error when right clicking on the slot, removing that line or changing the fix I suggested make everything works again. I can confirm ttNinterface.js:416 (from https://github.com/TinyTerra/ComfyUI_tinyterraNodes) is not the cause, it is just due to slot data passed from the incorrect call undefined where instead it should be the valid slot data.

[ty0x2333]

Thank you. This is indeed a bug. I will release a minor version to fix it. @Trung0246