Upgrade values to try fix interpolation and gamut clipping #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
OkLab_LMSg
is now [[1. x x] [1. x x] [1. x x]]LMS_lRGB
and before this PR we had two different source so value was not homogene internallylmfit
wich use https://en.wikipedia.org/wiki/Levenberg%E2%80%93Marquardt_algorithmas with two steps, the error was super low, i changed the halleys steps from 3 to 2
i did some refacto
and fixed tests
Details
You can have a look at the notebook here: https://colab.research.google.com/drive/14ujBZID5n6xlQ2B11iDGrlAAb6ngGO2Q#scrollTo=WbbkYzSjBYbl
Results