Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade values to try fix interpolation and gamut clipping #4

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

tychota
Copy link
Owner

@tychota tychota commented Nov 23, 2023

What

image
  • i also use the new matrix in OkLab Gamut matrix: those number are implicitly LMS_lRGBand before this PR we had two different source so value was not homogene internally
image
  • i recomputed the cutoff point to match new values
image image
  • as with two steps, the error was super low, i changed the halleys steps from 3 to 2

  • i did some refacto

  • and fixed tests

Details

You can have a look at the notebook here: https://colab.research.google.com/drive/14ujBZID5n6xlQ2B11iDGrlAAb6ngGO2Q#scrollTo=WbbkYzSjBYbl

Results

image image image

@tychota tychota force-pushed the fix/upgrade-values-oklab branch from a65f1a8 to 76587d5 Compare November 23, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant