Use chrono::OutOfRangeError
#5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will do, thanks for the PR. |
|
Thank you! |
|
(Just for context on a potential crates.io release, there is a seemingly active project that depends on float_duration other than your game_time, that might mostly be helpful to them.) |
|
@tylerreisinger Could you push a new release of this crate to crates.io? The latest release there is still v0.3.3 from 6 years ago (which is incompatible with current versions of chrono). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version 0.4.23 chrono has its own
OutOfRangeError.It is currently a re-export of
time::OutOfRangeError, but we would like to break that in chrono in a minor release.The reason is that there is a security advisory against time 0.1 that bugs many downstream users of chrono, while only a handful of crates, including yours, rely on the types in time 0.1 and chrono being the same.
Will you please accept this PR, and maybe release a new minor version?