Make flake8-bandit work with latest bandit 1.7.3 too #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: tylerwince#21 flake8-bandit 1.7.3 (PyCQA/bandit#496) introduced an `fdata` argument and this just passes a `None` to make things work with the latest version of bandit.
|
@tylerwince Please review. |
|
Can we do anything to help get this merged, @tylerwince? |
staticdev
suggested changes
Mar 1, 2022
| metrics=Metrics(), | ||
| ) | ||
| except TypeError: | ||
| # bandit < 1.7.3 (https://github.com/tylerwince/flake8-bandit/issues/21) |
There was a problem hiding this comment.
Personally I would use the other PR approach, no real need to create this compatibility code. It just makes the code less maintainable and not a huge gain...
There was a problem hiding this comment.
I'm not sure if we should pin versions in a package such as this one ...
There was a problem hiding this comment.
I agree @staticdev , the TypeError catch here makes an assumption that BanditNodeVisitor won't change again in future. We may just end up with a new generic TypeError being caused by the older call below, when in fact the root cause would be something else entirely.
Better to make two updates in this package, I feel:
- A patch update for
flake8-bandit(to v2.1.3) that sets thebanditversion insetup.pyto<1.7.3 - A minor update (to v2.2.0) that implements the backwards-incompatible change in Make flake8-bandit work with latest bandit 1.7.3 version #22 , and setting
bandit>=1.7.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #21
flake8-bandit 1.7.3 (PyCQA/bandit#496) introduced an
fdataargument and this just passes aNoneto make things work with the latest version of bandit.