This repository has been archived by the owner on Mar 8, 2021. It is now read-only.
Fix driver support checking for custom drivers #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tymondesigns
added a commit
that referenced
this pull request
Jun 16, 2015
Fix driver support checking for custom drivers
|
Yea this makes sense, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
localStorageis not available, Locker does not work properly with other drivers. When Locker's functions call_checkSupport()(without any parameters), it checks if the browser supportslocalStoragespecifically, even if that instance is using some other driver. This only really causes an issue iflocalStorageis not available, when using some other driver as a fallback is most critical.Please let me know what your thoughts are.