allow nbf to be a future date when creating a token - closes #1698

tymondesigns · Oct 17, 2018 · b860a4c · b860a4c
1 parent 1eac56e
commit b860a4c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 29 deletions.
diff --git a/src/Claims/NotBefore.php b/src/Claims/NotBefore.php
@@ -16,29 +16,13 @@
 
 class NotBefore extends Claim
 {
-    use DatetimeTrait {
-        validateCreate as commonValidateCreate;
-    }
+    use DatetimeTrait;
 
     /**
      * {@inheritdoc}
      */
     protected $name = 'nbf';
 
-    /**
-     * {@inheritdoc}
-     */
-    public function validateCreate($value)
-    {
-        $this->commonValidateCreate($value);
-
-        if ($this->isFuture($value)) {
-            throw new InvalidClaimException($this);
-        }
-
-        return $value;
-    }
-
     /**
      * {@inheritdoc}
      */

diff --git a/tests/Claims/NotBeforeTest.php b/tests/Claims/NotBeforeTest.php
@@ -16,16 +16,6 @@
 
 class NotBeforeTest extends AbstractTestCase
 {
-    /**
-     * @test
-     * @expectedException \Tymon\JWTAuth\Exceptions\InvalidClaimException
-     * @expectedExceptionMessage Invalid value provided for claim [nbf]
-     */
-    public function it_should_throw_an_exception_when_passing_a_future_timestamp()
-    {
-        new NotBefore($this->testNowTimestamp + 3600);
-    }
-
     /**
      * @test
      * @expectedException \Tymon\JWTAuth\Exceptions\InvalidClaimException

diff --git a/tests/Validators/PayloadValidatorTest.php b/tests/Validators/PayloadValidatorTest.php
@@ -75,8 +75,8 @@ public function it_should_throw_an_exception_when_providing_an_expired_payload()
 
     /**
      * @test
-     * @expectedException \Tymon\JWTAuth\Exceptions\InvalidClaimException
-     * @expectedExceptionMessage Invalid value provided for claim [nbf]
+     * @expectedException \Tymon\JWTAuth\Exceptions\TokenInvalidException
+     * @expectedExceptionMessage Not Before (nbf) timestamp cannot be in the future
      */
     public function it_should_throw_an_exception_when_providing_an_invalid_nbf_claim()
     {