Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function fromUser expects type User #5

Closed
damacisaac opened this issue Oct 13, 2014 · 4 comments
Closed

function fromUser expects type User #5

damacisaac opened this issue Oct 13, 2014 · 4 comments

Comments

@damacisaac
Copy link

Since fromUser() expects a type User, I'm unable to move my user class into my own directory i.e. Application\User\User. I think it's common to want to move your models into your own application directory and it might be useful to accept different types.

@tymondesigns
Copy link
Owner

Yea that's definitely going to come up, I think will remove the typehint for now. Thanks

@tymondesigns
Copy link
Owner

Actually, after looking and refreshing my memory, the fromUser() method no longer has the User typehint as of version 0.3.*.

However it has made me realise the toUser() method does assume \User which isn't great.
So I will need to add a config option to allow a full class path to the User class to be specified.

@damacisaac
Copy link
Author

Great! Thanks for the quick reply.

@tymondesigns
Copy link
Owner

fixed with 0.3.3 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants