Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Carbon 3.X #2247

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Add support for Carbon 3.X #2247

merged 1 commit into from
Mar 14, 2024

Conversation

RBFraphael
Copy link
Contributor

Adds ^3.0 version tag to the nesbot/carbon dependency on composer.json file, to fit on Laravel 11's dependencies.

@tymondesigns tymondesigns merged commit 51620eb into tymondesigns:2.x Mar 14, 2024
1 check passed
@amir-khoshbakht
Copy link

amir-khoshbakht commented Mar 25, 2024

https://github.com/briannesbitt/Carbon/blob/6b6383ae361003ec25488d0a1cde9551bb25e955/src/Carbon/Traits/Difference.php#L378

In the new version of the Carbon library, the signature of this function has changed from true to false.
this breaks blacklisting functionality.

return $exp->max($iat->addMinutes($this->refreshTTL))->addMinute()->diffInRealMinutes();

more here :
#2250 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants