This repository has been archived by the owner on Dec 31, 2022. It is now read-only.
chore(deps): upgrade Ember CLI to latest #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Node 8 is long since out of LTS support
chriskrycho
force-pushed
the
bump-ember-cli
branch
2 times, most recently
from
f565101
to
a697276
Compare
BREAKING CHANGE: drops all support for pre-[RFC 0232][rfc] blueprints, since these have long since been replaced. Note that this commit also removes the component blueprints entirely, in favor of landing updated versions of them in [another PR][pr]. [rfc]: https://emberjs.github.io/rfcs/0232-simplify-qunit-testing-api.html [pr]: #213
chriskrycho
force-pushed
the
bump-ember-cli
branch
from
a697276
to
8c6a016
Compare
|
Travis is borked. AppVeyor and Azure Pipelines are both testing Windows. 🤦♂️ #215 looks, uhh, even more worthwhile now. Edit: Travis was borked b/c I hadn't updated the lock file to match |
|
Note that the CI changes I made here get everything to pass, but will be superseded by #217. It's probably easiest (no rebase to manage) if we land this first, then land that as it should be a clean diff. |
This was referenced Nov 15, 2020
dfreeman
approved these changes
Nov 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is really preparatory work for other cleanup; it just gets us to the point where the test suite is actually useful again.
We need to add support for testing against ember-qunit 5.0 and its blueprints in a future update, and we also need to go ahead and clean up the actual contents of these blueprints, but that's follow-on work!