-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build fails with typescript 3.8.2 #1103
Comments
change typescript version from ^3.8.2 to 3.7.5. yarn add typescript@3.7.5 |
Yes, downgrading to 3.7.5 works! |
We're watching TS 3.8 releases closely, and not currently recommending it to anyone because of the amount of breakage we're seeing. In case anyone else comes along: I'll update this comment and add another one if/when we see a solid-enough 3.8 point release or if 3.9 stabilizes these issues. |
To make at least the floating dependency test pass again, and unlock all those dependabot PRs that are currently not mergable due to this. See typed-ember/ember-cli-typescript#1103
I've got this narrowed down to a relatively small reproduction in https://github.com/dfreeman/typescript-3.8-debug-failure, and bisected the 3.8-dev releases to find which one it started happening in. I reported what I found on microsoft/TypeScript#37015 (comment), which will hopefully be reopened (and likely shouldn't have been closed in the first place), so we'll see what happens from here. |
Update: the issue has since been reopened, labeled a bug, and added to the TS 3.9 milestone. |
Might want to change what's installed by default. I got this on a brand new project after just |
@luketheobscure it's a reasonable thought, but there's a tradeoff there: it means constant vetting of new TS versions and bumps here, and cutting a looooot more releases. That's not a massive amount of work, but it's also not nothing. I think it's likely we will get there, but none of us have the time to do that at the moment. 😬 That said, the reason I think it's likely we'll get there is that we have a medium-term goal of improving stability and reliability throughout the Ember TS ecosystem (hopefully with benefits for the wider TS ecosystem as well!) and adjusting this is likely a part of that. |
- Fix test build failures by locking `typescript` version to `3.7.5` as suggested by typed-ember/ember-cli-typescript#1103 - Add `.nvmrc` file to specify `node: 10` which fixes failing `netlify` build due to `The engine "node" is incompatible with this module. Expected version ">= 10.*".` - Also disable `no-quoteless-attributes` rule for `ember-cli-template-lint` Co-authored-by: Jeremy Taylor <jmtaylor@apple.com>
so sad! I was going to use a dep that is using a ts 3.8 feature... but I can't :( |
Typescript 3.8.x fails the build with current ember-cli-typescript setup. We pin the typescript-version to 3.7.5 until this is fixed. Reference: typed-ember/ember-cli-typescript#1103
So with TS 3.9.2, our build is passing again 🎉 . Do you think it is safe to update to 3.9.2 (and close this issue)? |
Yep! Was actually going to circle back this week and check! If anyone else has this issue in 3.9 please report here and we'll reopen. |
Yay! I have different issues now, related to mirage, but this one is gone! |
Please paste the output of
ember -v
hereember-cli: 3.16.0
node: 12.13.1
os: linux x64
Please paste the output of
tsc -v
hereVersion 3.8.2
Please paste the version of
ember-cli-typescript
andember-cli-typescript-blueprints
here├─ @glimmer/component@1.0.0
│ └─ ember-cli-typescript@3.0.0
├─ ember-cli-typescript-blueprints@3.0.0
├─ ember-cli-typescript@3.1.3
├─ ember-concurrency-decorators@1.0.0
│ └─ ember-cli-typescript@2.0.2
└─ ember-load-initializers@2.1.1
└─ ember-cli-typescript@2.0.2
What are instructions we can follow to reproduce the issue?
Reproduction Case
Updating typescript from 3.7.5 to 3.8.2 breaks the build. Downgrading again fixes it.
Now about that bug. What did you expect to see?
I can build the app.
What happened instead?
I think this is the actual issue at the core of #1101
The text was updated successfully, but these errors were encountered: