Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings when using ember-cli-babel 8.x #1567

Closed
LucasHillDex opened this issue Aug 25, 2023 · 1 comment · Fixed by #1569
Closed

Warnings when using ember-cli-babel 8.x #1567

LucasHillDex opened this issue Aug 25, 2023 · 1 comment · Fixed by #1569
Labels
bug build Ideas for or bugs with the build process

Comments

@LucasHillDex
Copy link

LucasHillDex commented Aug 25, 2023 •
edited
Loading

Please paste the output of ember -v here

ember-cli: 3.28.6
node: 20.5.0
os: darwin arm64

Please paste the output of tsc -v here

Version 5.1.6

Please paste the version of ember-cli-typescript and ember-cli-typescript-blueprints here

ember-cli-typescript@5.2.1
ember-cli-typescript-blueprints@3.0.0

This warning appears when starting ember with ember-cli-babel version 8.0.0

WARNING: ember-cli-typescript requires ember-cli-babel ^7.17.0, but you have version 8.0.0 installed; your TypeScript files may not be transpiled correctly

Is ember-cli-typescript actually not compatible with this new version or does this version check need to get updated?
@basz
Copy link

basz commented Aug 30, 2023

i have noticed no problems between these two addons

@NullVoxPopuli NullVoxPopuli mentioned this issue Sep 7, 2023
Closed
chriskrycho added a commit that referenced this issue Sep 28, 2023
@chriskrycho
Loosen version check against ember-cli-babel
87f6e6d 
This gets us 'clean' support for interop with ember-cli-babel v8, which
works just fine with this package.

Fixes #1567
@chriskrycho chriskrycho mentioned this issue Sep 28, 2023
Merged
@chriskrycho chriskrycho added bug build Ideas for or bugs with the build process labels Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug build Ideas for or bugs with the build process
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Loosen version check against ember-cli-babel typed-ember/ember-cli-typescript
3 participants
@basz @chriskrycho @LucasHillDex