Skip to content

Fix type of locationType #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2022
Merged

Fix type of locationType #1466

merged 2 commits into from
Feb 3, 2022

Conversation

NullVoxPopuli
Copy link
Collaborator

In fresh apps, previously, we'd start with a TS error, which crashes ember-cli atm, due to an ember-cli issue.

@NullVoxPopuli
Fix typef of locationType
0285cfe 
In fresh apps, previously, we'd start with a TS error, which crashes ember-cli atm, due to an ember-cli issue.
chriskrycho
chriskrycho approved these changes Jan 23, 2022
View reviewed changes
Copy link
Member

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@NullVoxPopuli NullVoxPopuli changed the title Fix typef of locationType Fix type of locationType Jan 23, 2022
This was referenced Jan 24, 2022
Closed
Closed
@chriskrycho chriskrycho merged commit 873109c into typed-ember:master Feb 3, 2022
@chriskrycho chriskrycho added the bug label Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskrycho chriskrycho chriskrycho approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NullVoxPopuli @chriskrycho