Skip to content

Ignore no-empty-interface in the default app index.d.ts #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 22, 2022
Merged

Ignore no-empty-interface in the default app index.d.ts #1484

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb87713
lint: Add an eslint-ignore line allowing for empty interfaces just th…
muziejus Feb 22, 2022
1c4ef95
add an explanation to eslint-disable
chriskrycho Feb 22, 2022
1b06a18
Prettier-ify the blueprint index
chriskrycho Feb 22, 2022
6b6c896
Merge branch 'master' into ignore-no-empty-interface
chriskrycho Feb 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ts/blueprints/ember-cli-typescript/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ const path = require('path');
const APP_DECLARATIONS = `import Ember from 'ember';

declare global {
// Prevents ESLint from "fixing" this via its auto-fix to turn it into a type
// alias (e.g. after running any Ember CLI generator)
// eslint-disable-next-line @typescript-eslint/no-empty-interface
interface Array<T> extends Ember.ArrayPrototypeExtensions<T> {}
// interface Function extends Ember.FunctionPrototypeExtensions {}
}
Expand Down Expand Up @@ -233,7 +236,7 @@ module.exports = {
if (scripts[type] && scripts[type] !== script) {
this.ui.writeWarnLine(
`Found a pre-existing \`${type}\` script in your package.json. ` +
`By default, ember-cli-typescript expects to run \`${script}\` in this hook.`
`By default, ember-cli-typescript expects to run \`${script}\` in this hook.`
);
return;
}
Expand Down