Skip to content

Clarify babel version error message #1500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Conversation

pjcarly
Copy link
Contributor

@pjcarly pjcarly commented Apr 26, 2022

As discussed on Discord, the error message is a little confusing, this way it clarifies some potential problems.

Copy link
Member

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! I'll merge once CI is ✅!

@pjcarly
Copy link
Contributor Author

pjcarly commented Apr 26, 2022

Fixed the linting failure. But no idea what the other issue is

@chriskrycho
Copy link
Member

Totally unrelated, something we need to fix as part of improvements they made in the the upcoming TS 4.7 release. Thank you so much!

@chriskrycho chriskrycho merged commit d2ce222 into typed-ember:master Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants