Adding note to testing.md about qunit-dom #1562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskrycho
approved these changes
Sep 29, 2023
Member
chriskrycho
left a comment
chriskrycho
left a comment
There was a problem hiding this comment.
Ah, this is good to have here. qunit-dom's own docs also cover this, and I believe the blueprints shipped in ember-source do the right thing, but this is great to have. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just adds a small snippet to the
testing.mdpage about importingqunit-domso that Typescript is aware of theassert.dom()function commonly used in Component tests.It took me a while to figure this out, so I hope that this small snippet can save others some time in the future.