Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen version check against ember-cli-babel #1569

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Loosen version check against ember-cli-babel #1569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ts/addon.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ export default addon({
let babel = this.parent.addons.find((addon) => addon.name === 'ember-cli-babel');
let version = babel && babel.pkg.version;

if (!babel || !(semver.gte(version!, '7.17.0') && semver.lt(version!, '8.0.0'))) {
if (!babel || !semver.gte(version!, '7.17.0')) {
let versionString = babel
? `version ${babel.pkg.version} installed`
: `no instance of ember-cli-babel installed in your dependencies (check if it's in devDependencies instead?)`;
Expand Down
Loading