Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After learning way more about the internals of broccoli and ember-cli than I'd expected to today ...
Using broccoli-stew to print out the
inputNode
intoTree
, I noticed that it was being passedThis seems to only be the case for the
addon
directory, which is why I think it wasn't breaking in 'normal' app usage. ThetoTree
hook gets called three times (addon, app and tests). The tree received when invoked byapp
is quite different to the one fromaddon
.After digging around I noticed in here https://ember-cli.com/api/classes/Addon.html#method_setupPreprocessorRegistry that the file extension is used to determine the tree that the preProcessor receives.
Adding the extension to the
TypeScriptPreprocessor
changes it to thisWhich results in the typescript files being correctly passed to the tsc compiler.