Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary export keyword in blueprint #69

Merged
merged 3 commits into from
Nov 13, 2017
Merged

Conversation

dwickern
Copy link
Contributor

I'm pretty sure export is implied. The typings seem to work without it.

@chriskrycho
Copy link
Member

The build is breaking because of the changes to RSVP. 😒 Also, why isn't Travis reporting status? Argh.

@chriskrycho
Copy link
Member

chriskrycho commented Sep 13, 2017

@dwickern even worse: after some investigation, the problem is that when the DefinitelyTyped modules are shipped, the tsconfig is apparently stripped. So having that setting local to Ember.js' typings and even in this repo fails. 😑 How far do you think we are from being able to do a release of the Ember typings you and @dfreeman have been working on for users to depend on?

I'll make it a priority to ship correct RSVP typings upstream so we can just have those in place directly.

@dwickern
Copy link
Contributor Author

So my understanding from DefinitelyTyped/DefinitelyTyped#18872 is that our ember typings need to import RSVP = require('rsvp') and our tsconfig blueprint needs to have allowSyntheticDefaultImports?

@chriskrycho
Copy link
Member

I think that should work, I guess? Ugh. Will allocate an hour to this tomorrow.

@chriskrycho
Copy link
Member

As with #83, the Travis failure is spurious. Underlying issue is ember-cli/ember-try#161.

@chriskrycho chriskrycho merged commit fe59313 into master Nov 13, 2017
@chriskrycho chriskrycho deleted the no-export branch November 13, 2017 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants