Ensure errors are emitted when ts:precompile fails #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Floating-deps tests should start passing again once zloirock/core-js#710 is resolved |
|
Updated from master, rerunning CI now. Also reviewing! |
chriskrycho
reviewed
Dec 5, 2019
| '--pretty', 'true', | ||
| ], { | ||
| preferLocal: true, | ||
| all: true, |
There was a problem hiding this comment.
Would you mind adding a comment here explaining why we want this? Will make maintenance easier. (I just went and read the execa docs to figure it out, figure it'll save us time in the future from doing the same.)
There was a problem hiding this comment.
Done! execa is one of those that I've used enough places that I've lost any good sense of which options are self-describing and which aren't 🙃
chriskrycho
approved these changes
Dec 5, 2019
|
Thanks, I just hit this bug and was about to make the same PR when I saw it's already fixed on master. |
Closed
|
Released in 3.1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted both in Discord and in #973, we currently don't emit any of
tsc's output when it fails duringts:precompile. This ensures we capture and re-emit any output when the command exits with a nonzero code, and adds a test to make sure we don't regress in the future.