This repository has been archived by the owner on Jul 6, 2018. It is now read-only.
make Transition public #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re: https://github.com/emberjs/rfcs/blob/master/text/0095-router-service.md#transition-object Also removes the duplicate (and unused) EmberTesting namespace and globalArray type.
|
Very nice! Could you add some tests using code snippets from the guides? |
5 tasks
# Conflicts: # types/ember/index.d.ts
dwickern
force-pushed
the
unused-namespaces
branch
from
3264330
to
4f33b9c
Compare
# Conflicts: # types/ember/tsconfig.json
dwickern
force-pushed
the
unused-namespaces
branch
from
4f33b9c
to
e6989ba
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: https://github.com/emberjs/rfcs/blob/master/text/0095-router-service.md#transition-object
Also removes the duplicate (and unused) EmberTesting namespace and
globalArray type.