Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add template import type for uniqueId helper #723

Open
wants to merge 1 commit into
base: v1.x
Choose a base branch
from
Open

Add template import type for uniqueId helper #723

wants to merge 1 commit into from

Conversation

vstefanovic97
Copy link

This in combination with DefinitelyTyped/DefinitelyTyped#69687 should make importing uniqueId from @ember/helper work

@NullVoxPopuli
Copy link
Contributor

Why does glint need code changes at all?

@vstefanovic97
Copy link
Author

Why does glint need code changes at all?

@NullVoxPopuli as far as I can tell the types defined in https://github.com/DefinitelyTyped/DefinitelyTyped/pull/69687/files#diff-ee310ca708dd6726cf0487230fae7935b0eecd94c32c37e022b0776a82506bb7R15
don't have any real type information and we rely on extending the interfaces here in glint

@NullVoxPopuli
Copy link
Contributor

We may need to start a 1.x branch, because main is currently breaking, preparing for v2 / a new approach to glint

@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Jun 20, 2024
@NullVoxPopuli
Copy link
Contributor

This'll be in the main/2.x release (which may be unstable for a while).
(looks like you have lint issues though)

We can release this in 1.x if you also make this PR for here: https://github.com/typed-ember/glint/tree/v1.x

@vstefanovic97 vstefanovic97 force-pushed the add-template-import-type-for-unique-id-helper branch from c5748f6 to 92b0cf8 Compare June 26, 2024 08:58
@vstefanovic97 vstefanovic97 changed the base branch from main to v1.x June 26, 2024 08:58
@vstefanovic97
Copy link
Author

@NullVoxPopuli I rebased it and repointed to the v1.x branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working waiting on author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstefanovic97 @NullVoxPopuli