Refactor how version is provided for Maven deployment #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haikalpribadi
approved these changes
Oct 10, 2019
haikalpribadi
pushed a commit
to typedb/typedb
that referenced
this pull request
Oct 10, 2019
## What is the goal of this PR? typedb/bazel-distribution#191 changed the way how version should be provided for Maven deployment. This PR adapts Grakn Core to latest changes. ## What are the changes implemented in this PR? * Pass `version` as a `--define` argument to `bazel` instead of `deploy_maven` * Remove deployment of `daemon` and `server` into Maven repo * Upgrade `build-tools`
This was referenced Oct 11, 2019
haikalpribadi
pushed a commit
to typedb/typedb-protocol
that referenced
this pull request
Oct 11, 2019
## What is the goal of this PR? typedb/bazel-distribution#191 changed the way Maven JARs are built. This PR adapts `protocol` to latest changes ## What are the changes implemented in this PR? * Use `--define` to supply version to Maven deployment rule * Remove `version_file` from `assemble_maven` arguments
haikalpribadi
pushed a commit
to typedb/typeql
that referenced
this pull request
Oct 11, 2019
## What is the goal of this PR? typedb/bazel-distribution#191 changed the way Maven JARs are built. This PR adapts `graql` to latest changes ## What are the changes implemented in this PR? * Use `--define` to supply version to Maven deployment rule * Remove `version_file` from `assemble_maven` arguments
haikalpribadi
pushed a commit
to typedb/typedb-driver
that referenced
this pull request
Oct 11, 2019
## What is the goal of this PR? typedb/bazel-distribution#191 changed the way Maven JARs are built. This PR adapts `protocol` to latest changes ## What are the changes implemented in this PR? * Use `--define` to supply version to Maven deployment rule * Remove `version_file` from `assemble_maven` arguments * Upgrade `@graknlabs_build_tools`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
Partial work on #150
What are the changes implemented in this PR?
deploy_mavenno longer accepts version as command-line argument. Additionally, it no longer modifiespom.xmlandjarwhich are to be deployed. Instead, it assumes that dependentassemble_maventarget is already properly versioned by providing--define version=<VERSION>