Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test leading digit is allowed in TypeQL Variables #281

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Test leading digit is allowed in TypeQL Variables #281

merged 1 commit into from
Feb 14, 2024

Conversation

flyingsilverfin
Copy link
Member

Usage and product changes

We test that variables can contain leading digits, while labels may not.

@typedb-bot
Copy link
Member

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.

Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@flyingsilverfin flyingsilverfin mentioned this pull request Feb 14, 2024
Merged
@flyingsilverfin flyingsilverfin merged commit 9608d28 into typedb:development Feb 14, 2024
1 of 2 checks passed
@flyingsilverfin flyingsilverfin deleted the allow-leading-var-digit branch February 14, 2024 16:36
flyingsilverfin added a commit to typedb/typeql that referenced this pull request Feb 15, 2024
@flyingsilverfin
Allow variables to have a leading digit (#317)
bf83077 
## Usage and product changes

We modify the behaviour of #310 which unified variables and labels to
have the same valid identifier syntax, which eliminated the capability
of variables to have a leading number. For example, the variable `$0`
was banned.

This PR reverts this specific behaviour, and enables usage of variables
with leading digits:
```
match
$1_a isa entity;
get;
```
is made valid again.

Testing specified in
typedb/typedb-behaviour#281

## Implementation

We split the identifier regexes and grammar rules that validated labels
and variables before, to be specific to `Variable` and `Label`
identifiers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flyingsilverfin @typedb-bot