-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hash for OR-Tools, remove unneccessary pip repositories call #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Code
Architecture
|
jamesreprise
added
type: refactor
priority: medium
dependencies
Pull requests that update a dependency file
labels
Oct 3, 2022
alexjpwalker
approved these changes
Oct 3, 2022
This was referenced Oct 3, 2022
jamesreprise
added a commit
to typedb/typedb-driver-python
that referenced
this pull request
Oct 3, 2022
## What is the goal of this PR? We remove an unneccessary call of `pip_repositories` despite it being a deprecated function from `rules_python`, including in our own patched version. Additionally, this cleans up our bazel command output. See the output message below. ``` DEBUG: /private/var/tmp/[...]/external/rules_python/python/pip.bzl:228:10: DEPRECATED: the pip_repositories rule has been replaced with pip_install, please see rules_python 0.1 release notes ``` See this dependencies PR for more information: - typedb/typedb-dependencies#372 ## What are the changes implemented in this PR? We remove the command that loads the function as well as the call to the function.
flyingsilverfin
pushed a commit
to typedb/typedb-ml
that referenced
this pull request
Oct 4, 2022
## What is the goal of this PR? We remove an unneccessary call of `pip_repositories` despite it being a deprecated function from `rules_python`, including in our own patched version. Additionally, this cleans up our bazel command output. See the output message below. ``` DEBUG: /private/var/tmp/[...]/external/rules_python/python/pip.bzl:228:10: DEPRECATED: the pip_repositories rule has been replaced with pip_install, please see rules_python 0.1 release notes ``` See this dependencies PR for more information: - typedb/typedb-dependencies#372 ## What are the changes implemented in this PR? We remove the command that loads the function as well as the call to the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
Currently, there are a number of warnings output by Bazel upon syncing dependencies. These four warnings provide some recommendations as to how we can improve the state of the repository. Additionally, fixing the problems associated with warnings is good practice as it prevents developers from becoming used to warnings and potentially missing something important. Case in point: if someone were to compromise the google/or-tools repository and replace the releases we download with compromised packages, Bazel wouldn't know.
We are currently missing a hash for our
http_archive
downloads forgoogle_or_tools_*
. This reduces hermeticity.We currently call pip_repositories, despite the fact that it is a deprecated method. See the method body:
What are the changes implemented in this PR?
google_or_tools_*
http_archive
calls, increasing hermeticity.pip_repositories
.