This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Concept map JSON serialization #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Trivial Change
Code
Architecture
|
dmitrii-ubskii
changed the title
dmitrii-ubskii
requested review from
alexjpwalker and
flyingsilverfin
as code owners
dmitrii-ubskii
force-pushed
the
concept-map-json
branch
from
d0dfb6e to
2cc6161
Compare
dmitrii-ubskii
assigned dmitrii-ubskii and unassigned flyingsilverfin, alexjpwalker and benjaminasmall
typedb-bot
requested review from
benjaminasmall
and removed request for
benjaminasmall
typedb-bot
requested review from
benjaminasmall
and removed request for
benjaminasmall
typedb-bot
requested review from
benjaminasmall
and removed request for
benjaminasmall
dmitrii-ubskii
commented
Mar 23, 2023
Comment on lines
+35
to
+44
| class UnorderedEqualTo(BaseMatcher, Generic[T]): | ||
| def __init__(self, expected: List[T]): | ||
| self.expected = Counter([json.dumps(item, sort_keys=True) for item in expected]) | ||
|
|
||
| def _matches(self, actual: List[T]) -> bool: | ||
| actual = Counter([json.dumps(item, sort_keys=True) for item in actual]) | ||
| return actual == self.expected | ||
|
|
||
| def describe_to(self, description): | ||
| description.append_text('is equal, in any order, to ').append_text(repr(self.expected)) |
There was a problem hiding this comment.
A hamcrest matcher that essentially performs multiset comparisons. Since dicts aren't hashable, we serialize each one in a well-defined way and compare the strings.
benjaminasmall
approved these changes
Mar 23, 2023
Comment on lines
+35
to
+44
| class UnorderedEqualTo(BaseMatcher, Generic[T]): | ||
| def __init__(self, expected: List[T]): | ||
| self.expected = Counter([json.dumps(item, sort_keys=True) for item in expected]) | ||
|
|
||
| def _matches(self, actual: List[T]) -> bool: | ||
| actual = Counter([json.dumps(item, sort_keys=True) for item in actual]) | ||
| return actual == self.expected | ||
|
|
||
| def describe_to(self, description): | ||
| description.append_text('is equal, in any order, to ').append_text(repr(self.expected)) |
| @@ -19,7 +19,7 @@ | |||
| # under the License. | |||
| # | |||
| from abc import ABC, abstractmethod | |||
| from typing import Mapping, Iterable, Tuple | |||
| from typing import Iterable, Mapping, Tuple, Union | |||
There was a problem hiding this comment.
Iterable is unused I think, double-check the rest of the PR for dangling unused imports
There was a problem hiding this comment.
It's used on L34.
alexjpwalker
approved these changes
Mar 23, 2023
dmitrii-ubskii
force-pushed
the
concept-map-json
branch
from
2cc6161 to
59eae5d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
We implement the JSON serialization of concept maps according to typedb/typedb-behaviour#238.