Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Define user password expiry in terms of seconds #288

Merged
merged 42 commits into from
Apr 21, 2023

Conversation

jamesreprise
Copy link
Contributor

@jamesreprise jamesreprise commented Apr 5, 2023

What is the goal of this PR?

We've redefined the way we expose how long until a password expires in seconds, rather than days as was done previously.

What are the changes implemented in this PR?

  • We've changed password_expiry_days to password_expiry_seconds.
  • We implement the newly updated BDD steps to do with opening and closing connections, and prepare other steps for booting and configuring TypeDB for use once the TypeDB runner is available in Python

@typedb-bot
Copy link
Member

typedb-bot commented Apr 5, 2023

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@jamesreprise
Copy link
Contributor Author

Still waiting on 2.17.0 release from both servers. Also need to update behaviour, though this is likely to be time intensive.

@flyingsilverfin flyingsilverfin marked this pull request as ready for review April 21, 2023 17:24
@flyingsilverfin flyingsilverfin changed the title Define password expiry in terms of seconds Define user password expiry in terms of seconds Apr 21, 2023
@flyingsilverfin flyingsilverfin merged commit c50bb05 into typedb:master Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants