This repository was archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
Define user password expiry in terms of seconds #288
Merged
flyingsilverfin
merged 42 commits into
typedb:master
from
jamesreprise:password-expiry-secs
Apr 21, 2023
Merged
Define user password expiry in terms of seconds #288
flyingsilverfin
merged 42 commits into
typedb:master
from
jamesreprise:password-expiry-secs
Apr 21, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Trivial Change
Code
Architecture
|
flyingsilverfin
approved these changes
Apr 5, 2023
Still waiting on 2.17.0 release from both servers. Also need to update behaviour, though this is likely to be time intensive. |
81a3765
to
224c043
Compare
a560ef1
to
1473b6f
Compare
3931f71
to
6fbf524
Compare
flyingsilverfin
approved these changes
Apr 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
We've redefined the way we expose how long until a password expires in seconds, rather than days as was done previously.
What are the changes implemented in this PR?
password_expiry_days
topassword_expiry_seconds
.