Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Fix Factory Badge #295

Merged
merged 1 commit into from
May 23, 2023
Merged

Fix Factory Badge #295

merged 1 commit into from
May 23, 2023

Conversation

jamesreprise
Copy link
Contributor

What is the goal of this PR?

We've updated the Factory badge from the old 'Grabl' badge that is no longer active.

What are the changes implemented in this PR?

Updated embedded badge link and URL in the README.

@typedb-bot
Copy link
Member

typedb-bot commented May 23, 2023

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@flyingsilverfin flyingsilverfin merged commit ea839a8 into master May 23, 2023
@flyingsilverfin flyingsilverfin deleted the fix-factory-badge branch May 23, 2023 09:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants