-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test datetime attribute insert and match time-zone invariant #424
Merged
+14
−4
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
dc7c680
Added step implementation for setting Java Timezone + fixed parsing
shiladitya-mukherjee 4fe4311
empty
shiladitya-mukherjee c6ea43f
fixed checkstyle
shiladitya-mukherjee d80882d
added step implementation in util file
shiladitya-mukherjee 46df389
fixed PR issues
shiladitya-mukherjee 68e1b58
Fixed set time-zone
shiladitya-mukherjee e4db426
added linebreak in import statement
shiladitya-mukherjee da7f0e9
removed unused import
shiladitya-mukherjee f2c0882
added Vaticle dependency
shiladitya-mukherjee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -645,13 +645,13 @@ public boolean check(Concept concept) { | |
} | ||
} | ||
|
||
public static class AttributeUniquenessCheck { | ||
public static abstract class AttributeUniquenessCheck { | ||
|
||
protected final Label type; | ||
protected final String value; | ||
|
||
AttributeUniquenessCheck(String typeAndValue) { | ||
String[] s = typeAndValue.split(":"); | ||
String[] s = typeAndValue.split(":", 2); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not a huge fan of this but I think we'll take it for now. Thoughts: it's not obvious how this is going to interplace with the next assertion line, and what it means about the format of the 'typeAndValue' identifier we're expecting (less explainable in 1 short sentence IMO) |
||
assertEquals( | ||
String.format("A check for attribute uniqueness should be given in the format \"type:value\", but received %s.", typeAndValue), | ||
2, s.length | ||
|
@@ -745,7 +745,7 @@ public static class ValueUniquenessCheck implements UniquenessCheck { | |
private final String value; | ||
|
||
ValueUniquenessCheck(String valueTypeAndValue) { | ||
String[] s = valueTypeAndValue.split(":"); | ||
String[] s = valueTypeAndValue.split(":", 2); | ||
this.valueType = s[0].toLowerCase().strip(); | ||
this.value = s[1].strip(); | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch!