Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix variance for migration operations #1707

Merged
merged 3 commits into from
Sep 12, 2023
Merged

fix variance for migration operations #1707

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23ecc69
fix variance for migration operations
asottile Sep 12, 2023
b3812cd
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 12, 2023
5184d4d
Update migration.pyi
asottile Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion django-stubs/db/migrations/migration.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
from collections.abc import Sequence

from django.db.backends.base.schema import BaseDatabaseSchemaEditor
from django.db.migrations.operations.base import Operation
from django.db.migrations.state import ProjectState
from typing_extensions import Self

class Migration:
operations: list[Operation]
operations: Sequence[Operation]
dependencies: list[tuple[str, str]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically others can also be changed, because they are only used as Iterable. But, it is up to you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat! I'll leave this as is for now since I didn't hit any issues with the others

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sobolevn @asottile I'll make another PR now to change the others.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1710

run_before: list[tuple[str, str]]
replaces: list[tuple[str, str]]
Expand Down