Fix/pyright unknown

[dephiros]

Fix unknown type error in mypy

Related issues

Format is:

• Closes Type of "method_decorator" is partially unknown (pyright) #1869

[flaeppe]

As far as I'm aware, regarding mypy, bounds in TypeAlias doesn't work as it's outside of class and function scope. Unfortunately _DECORATOR needs to be explicitly expanded to not end up with having _VIEW as Any.

For mypy it should probably be visible if you run a reveal_type(method_decorator) somewhere.

[flaeppe]

Here's a playground link that should describe what I'm after: https://mypy-play.net/?mypy=latest&python=3.12&gist=ab4e5d4b4d118bb2e78c146850483952

[flaeppe]

Perhaps we could define generics for the Callable here too, while we're at it?

Suggested change

	_T = TypeVar("_T", bound=View | Callable) # Any callable
	_T = TypeVar("_T", bound=View | Callable[..., Any])

[sobolevn]

Nit: let's please not name it _T, since it is bound to View it can be _ViewT or something

[flaeppe]

Hm, admin_view looks like a decorator. I think we want to use a TypeVar to not ruin any function signature using it. e.g.

Suggested change

	def admin_view(self, view: Callable[..., HttpResponse], cacheable: bool = ...) -> Callable[..., HttpResponse]: ...
	def admin_view(self, view: F, cacheable: bool = ...) -> F: ...

Where F could be a variable bound to a callable returning a HttpResponse

F = TypeVar("F", bound=Callable[..., HttpResponse])

[flaeppe]

👍