Issue 382 #384
Merged
Issue 382 #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kszmigiel
commented
Jun 2, 2020
kszmigiel
commented
- Closes Incorect type for items method of Sitemap class #382
stub for _build_app_dict (#351)
Revert "Allow template render to string helper functions to accept Co…
sobolevn
requested changes
Jun 2, 2020
| class SupportsCount(Protocol): | ||
| def count(self) -> int: ... | ||
|
|
||
| class SupportsOrdered(Protocol): |
Member
There was a problem hiding this comment.
Thanks a lot!
The only thing I see here is that we tend to use leading _ for our internal types.
Here's where this mistake comes from: https://github.com/typeddjango/django-stubs/blob/ef8850348b5862d39bfe529a39e71625c5d9c89d/django-stubs/core/paginator.pyi#L27
Can you please fix it in both places?
sobolevn
approved these changes
Jun 3, 2020
Member
|
Thanks a lot! |
Member
Author
|
No problem, trying to do my best 😁 |
sobolevn
pushed a commit
that referenced
this pull request
Jun 3, 2020
* proper redirect return type annotations made with Literal * Mapping instead of Dict type annotation for context in render() with test * removed Union and Context * typo Co-authored-by: Kacper Szmigiel <szmigielkacper@gmai.com> Add __init__ to OrderedSet (#381) Issue 382 (#384) * WIP fix, pushed for testing * added _ prefix for internal types Co-authored-by: Kacper Szmigiel <szmigielkacper@gmai.com> Fix parameter types for assertJSONEqual/NotEqual (#385) Add get_supported_language_variant (#386) Issue 309 (#383) * added tags for user models * type test for HttpRequest.user * test for User and AnonymousUser tags * httrequest test fix * checking python version fix for readibility * Rewrite version check for readability * Annotate is_authenticated/is_anonymous with Literal-type * Add auth in INSTALLED_APPS in test * Fix wrong type assertion in test * Fix misconception of how branch-testing works * Remove user from WSGIRequest * Change HttpRequest-transformer to set user-type to include AnonymousUser * Add check for anonymous_user_info=None to appease mypy * Isort transformers/request * Remove trailing whitespace * Remove unused import Co-authored-by: Kacper Szmigiel <szmigielkacper@gmai.com> * fix formatting and unused import * reformatted again Co-authored-by: Kacper Szmigiel <szmigielkacper@gmai.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.