Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@flaeppe This is some example fallout from typeddjango/django-stubs#1814 since
RelatedManager
base class was changed fromManager
toBaseManager
.Without this change, I can no longer pass
RelatedManager
s to APIs that accept them.I'm not entirely happy or sure about this. I think in pratice most managers, including
RelatedManager
s, do inherit fromManager
.BaseManager
seems to be intended as an impementation detail in Django, not something users should be exposed to. But this will force users to replaceManager
type hints withBaseManager
, including my personal projects.Related issues
RelatedManager
todjango.db.models.fields.related_descriptors
django-stubs#1814