Minor correction to Object Array example, added Java Array example... #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The line for the Object :Array example was corrected to hide the existing definition for JInteger so the example compiles without errors. As well, a similar exampe for the use of Java Arrays (JByteArray in this case) was added. Both examples state the expected output.
|
|
This was referenced Jan 22, 2019
rahulmutt
approved these changes
Jan 22, 2019
There was a problem hiding this comment.
@GordonBGood Wonderful, thanks for fixing & adding outputs!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per issues #929, the
importline for the Object :Array example was corrected to hide the existing definition for JInteger so the example compiles without errors.As well, as per issue #930 a similar example for the use of Java Arrays (JByteArray in this case) was added.
The expected output was added to both examples.
How Has This Been Tested?
Only changes the documentation, but the changed/added examples were tested with "etlas run" using etlas version 1.5.0.0 and eta version 0.8.6b4.
Types of changes
Checklist: