Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#23 Compatibility with sbt 0.13.x #29

Merged
merged 5 commits into from
Apr 28, 2019
Merged

Conversation

Romastyi
Copy link
Contributor

This pull request contains:

  • Fix for Etlas download problem, which fails CI
  • Support for maven-repos field in .cabal file
  • Drop eta-init command, only configuration using DSL stayed
  • Compatibility with sbt 0.13.x

I think that all features from #23 done, isn't it?

Copy link
Member

@rahulmutt rahulmutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it does indeed look like it #23 is done. Next step is just to port all the gradle-eta examples and ensure they work.

@rahulmutt rahulmutt merged commit bd5f977 into typelead:master Apr 28, 2019
@Romastyi
Copy link
Contributor Author

Romastyi commented Apr 28, 2019

I think, that all of examples are done. The example-multi subproject is the port of original multi example. The example subproject contains all other features in itself: it contains tests like in the test example and assembly plugin covers functionality of the fatjar example. All example projects contains java/scala interoperability. Only feature which is not present this is using CPP extension like in the original simple example.

Do you mean to port directory structure or make division into projects like in gradle-eta?

@rahulmutt
Copy link
Member

Ok in that case, no need for more examples.

Would you be interested in writing documentation for the SBT plugin features that you've added, similar to this section? You need to submit a PR to the main eta repo for the changes.

Here's where the Gradle User Guide is sourced:

https://github.com/typelead/eta/tree/master/docs/0-user-guides/2-gradle-user-guide

@Romastyi
Copy link
Contributor Author

I'll try to write documentation. Can I do this based on Gradle Guide just modifying this according sbt-etaDSL?

@rahulmutt
Copy link
Member

That sounds perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants