Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll back to Scala.js 1.5.1 #185

Merged
merged 2 commits into from
Oct 21, 2021
Merged

Roll back to Scala.js 1.5.1 #185

merged 2 commits into from
Oct 21, 2021

Conversation

rossabaker
Copy link
Member

Pins back to our previously released version. We can bump later if that comes back into fashion, but we can't unbump.

Pins back to our previously released version.  We can bump later if that comes back into fashion, but we can't unbump.
@rossabaker
Copy link
Member Author

@armanbilge, did I do something stupid? I thought this was just like typelevel/cats#4018.

I was being ultraconservative before a release, but I'm just going to close this unless someone can point out my mistake within a 10-second glance.

@armanbilge
Copy link
Member

I think we need to roll back another dependency, that's already bumped to SJS 1.7. I suspect #183, checking now.

@rossabaker
Copy link
Member Author

Thanks. I would not spend much time: this isn't that important, given the shortage of scars on the Scala.js side and that almost all use is with http4s with 1.7.

@armanbilge
Copy link
Member

Ok my bad, it was #168. You need to bump that back to 1.2.0.

@rossabaker
Copy link
Member Author

I'm ambivalent on this one, but last chance to do it before I cut 1.2.0.

@rossabaker
Copy link
Member Author

Relates to typelevel/cats#4018.

It's reversible if we merge, but not reversible if we release without.

@rossabaker rossabaker merged commit 807e1ee into main Oct 21, 2021
@rossabaker rossabaker deleted the scalajs-1.5.1 branch October 21, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants