Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IORuntime.isUnderFiberContext #4204

Merged

Conversation

armanbilge
Copy link
Member

Follow-up to #4200. Makes more complex IOLocal/ThreadLocal interop possible in userland. cc @iRevive

Let's bikeshed (or not...) isUnderFiberContext and the property cats.effect.trackFiberContext. Not sure how I feel about "context".

@armanbilge armanbilge requested a review from djspiewak December 18, 2024 22:11
@iRevive
Copy link
Contributor

iRevive commented Dec 19, 2024

Here is the draft implementation: https://github.com/typelevel/otel4s/pull/870/files.
The tests pass locally.

Copy link
Member

@djspiewak djspiewak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Context" is the only bikeshed-worthy bit of this, IMO, and I think it's not a terrible noun. "Frame" also comes to mind but is more limited and makes less sense. I'll give it some more thought today but I think this is probably good as-is.

@djspiewak djspiewak merged commit 78a7cbc into typelevel:series/3.x Dec 20, 2024
29 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants