Replace machinist macros by plain forwarders

Partial fix for #2553.

Co-authored-by: drdozer <turingatemyhamster@gmail.com>

core/src/main/scala/cats/syntax/eq.scala

@@ -1,8 +1,6 @@
 package cats
 package syntax
 
-import cats.macros.Ops
-
 trait EqSyntax {
 
   /** not final so it can be disabled in favor of scalactic equality in tests */
@@ -11,8 +9,8 @@ trait EqSyntax {
 }
 
 final class EqOps[A: Eq](lhs: A) {
-  def ===(rhs: A): Boolean = macro Ops.binop[A, Boolean]
-  def =!=(rhs: A): Boolean = macro Ops.binop[A, Boolean]
+  def ===(rhs: A): Boolean = Eq[A].eqv(lhs, rhs)
+  def =!=(rhs: A): Boolean = Eq[A].neqv(lhs, rhs)
   def eqv(rhs: A): Boolean = Eq[A].eqv(lhs, rhs)
   def neqv(rhs: A): Boolean = Eq[A].neqv(lhs, rhs)
 }

core/src/main/scala/cats/syntax/group.scala

@@ -1,16 +1,14 @@
 package cats
 package syntax
 
-import cats.macros.Ops
-
 trait GroupSyntax extends SemigroupSyntax {
   // TODO: use simulacrum instances eventually
   implicit final def catsSyntaxGroup[A: Group](a: A): GroupOps[A] =
     new GroupOps[A](a)
 }
 
 final class GroupOps[A: Group](lhs: A) {
-  def |-|(rhs: A): A = macro Ops.binop[A, A]
-  def remove(rhs: A): A = macro Ops.binop[A, A]
-  def inverse(): A = macro Ops.unop[A]
+  def |-|(rhs: A): A = Group[A].remove(lhs, rhs)
+  def remove(rhs: A): A = Group[A].remove(lhs, rhs)
+  def inverse(): A = Group[A].inverse(lhs)
 }

core/src/main/scala/cats/syntax/hash.scala

@@ -1,8 +1,6 @@
 package cats
 package syntax
 
-import cats.macros.Ops
-
 trait HashSyntax {
 
   implicit def catsSyntaxHash[A: Hash](a: A): HashOps[A] =
@@ -15,5 +13,5 @@ final class HashOps[A: Hash](a: A) {
   /**
    * Gets the hash code of this object given an implicit `Hash` instance.
    */
-  def hash: Int = macro Ops.unop0[Int]
+  def hash: Int = Hash[A].hash(a)
 }

core/src/main/scala/cats/syntax/order.scala

@@ -1,7 +1,6 @@
 package cats
 package syntax
 
-import cats.macros.Ops
 import cats.kernel.Comparison
 
 trait OrderSyntax extends PartialOrderSyntax {
@@ -10,8 +9,8 @@ trait OrderSyntax extends PartialOrderSyntax {
 }
 
 final class OrderOps[A: Order](lhs: A) {
-  def compare(rhs: A): Int = macro Ops.binop[A, Int]
-  def min(rhs: A): A = macro Ops.binop[A, A]
-  def max(rhs: A): A = macro Ops.binop[A, A]
-  def comparison(rhs: A): Comparison = macro Ops.binop[A, Comparison]
+  def compare(rhs: A): Int = Order[A].compare(lhs, rhs)
+  def min(rhs: A): A = Order[A].min(lhs, rhs)
+  def max(rhs: A): A = Order[A].max(lhs, rhs)
+  def comparison(rhs: A): Comparison = Order[A].comparison(lhs, rhs)
 }

core/src/main/scala/cats/syntax/partialOrder.scala

@@ -1,21 +1,19 @@
 package cats
 package syntax
 
-import cats.macros.Ops
-
 trait PartialOrderSyntax extends EqSyntax {
   implicit final def catsSyntaxPartialOrder[A: PartialOrder](a: A): PartialOrderOps[A] =
     new PartialOrderOps[A](a)
 }
 
 final class PartialOrderOps[A](lhs: A)(implicit A: PartialOrder[A]) {
-  def >(rhs: A): Boolean = macro Ops.binop[A, Boolean]
-  def >=(rhs: A): Boolean = macro Ops.binop[A, Boolean]
-  def <(rhs: A): Boolean = macro Ops.binop[A, Boolean]
-  def <=(rhs: A): Boolean = macro Ops.binop[A, Boolean]
+  def >(rhs: A): Boolean = A.gt(lhs, rhs)
+  def >=(rhs: A): Boolean = A.gteqv(lhs, rhs)
+  def <(rhs: A): Boolean = A.lt(lhs, rhs)
+  def <=(rhs: A): Boolean = A.lteqv(lhs, rhs)
 
-  def partialCompare(rhs: A): Double = macro Ops.binop[A, Double]
-  def tryCompare(rhs: A): Option[Int] = macro Ops.binop[A, Option[Int]]
-  def pmin(rhs: A): Option[A] = macro Ops.binop[A, Option[A]]
-  def pmax(rhs: A): Option[A] = macro Ops.binop[A, Option[A]]
+  def partialCompare(rhs: A): Double = A.partialCompare(lhs, rhs)
+  def tryCompare(rhs: A): Option[Int] = A.tryCompare(lhs, rhs)
+  def pmin(rhs: A): Option[A] = A.pmin(lhs, rhs)
+  def pmax(rhs: A): Option[A] = A.pmax(lhs, rhs)
 }

core/src/main/scala/cats/syntax/semigroup.scala

@@ -1,16 +1,14 @@
 package cats
 package syntax
 
-import cats.macros.Ops
-
 trait SemigroupSyntax {
   // TODO: use simulacrum instances eventually
   implicit final def catsSyntaxSemigroup[A: Semigroup](a: A): SemigroupOps[A] =
     new SemigroupOps[A](a)
 }
 
 final class SemigroupOps[A: Semigroup](lhs: A) {
-  def |+|(rhs: A): A = macro Ops.binop[A, A]
-  def combine(rhs: A): A = macro Ops.binop[A, A]
-  def combineN(rhs: Int): A = macro Ops.binop[A, A]
+  def |+|(rhs: A): A = Semigroup[A].combine(lhs, rhs)
+  def combine(rhs: A): A = Semigroup[A].combine(lhs, rhs)
+  def combineN(rhs: Int): A = Semigroup[A].combineN(lhs, rhs)
 }

docs/src/main/tut/faq.md

@@ -21,7 +21,6 @@ position: 40
  * [Where is `IO`/`Task`?](#task)
  * [What does `@typeclass` mean?](#simulacrum)
  * [What do types like `?` and `λ` mean?](#kind-projector)
- * [What does `macro Ops` do? What is `cats.macros.Ops`?](#machinist)
  * [What is `tailRecM`?](#tailrecm)
  * [What does this symbol mean?](#symbol)
  * [How can I test instances against their type classes' laws?](#law-testing)
@@ -155,12 +154,6 @@ Cats defines a wealth of type classes and type class instances. For a number of
 
 **Enter [kind-projector](https://github.com/non/kind-projector)!** kind-projector is a compiler plugin which provides a convenient syntax for dealing with type lambdas. The symbols `?` and `λ` are treated specially by kind-projector, and expanded into the more verbose definitions that would be required were it not to be used. You can read more about kind-projector at the [project page](https://github.com/non/kind-projector).
 
-## <a id="machinist" href="#machinist"></a>What does `macro Ops` do? What is `cats.macros.Ops`?
-
-`macro Ops` invokes the [Machinist](https://github.com/typelevel/machinist) Ops macro, and is used in Cats in a number of places to enrich types with operations with the minimal possible cost when those operations are called in code. Machinist supports an extension mechanism where users of the macro can provide a mapping between symbolic operator names and method names. The `cats.macros.Ops` class uses this extension mechanism to supply the set of mappings that the Cats project is interested in.
-
-More about the history of machinist and how it works can be discovered at the [project page](https://github.com/typelevel/machinist), or [this article on the typelevel blog](http://typelevel.org/blog/2013/10/13/spires-ops-macros.html).
-
 ## <a id="tailrecm" href="#tailrecm"></a>What is `tailRecM`?
 
 The `FlatMap` type class has a `tailRecM` method with the following signature: