Add Test that actually hits the implicated ApplicativeError instance

typelevel · Aug 26, 2017 · d62e1e2 · d62e1e2
1 parent 1836c07
commit d62e1e2
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/core/src/main/scala/cats/Parallel.scala b/core/src/main/scala/cats/Parallel.scala
@@ -23,6 +23,8 @@ trait Parallel[M[_], F[_]] {
 
 object Parallel extends ParallelArityFunctions {
 
+  def apply[M[_], F[_]](implicit P: Parallel[M, F]): Parallel[M, F] = P
+
   /**
     * Like `Traverse[A].sequence`, but uses the applicative instance
     * corresponding to the Parallel instance instead.

diff --git a/tests/src/test/scala/cats/tests/ParallelTests.scala b/tests/src/test/scala/cats/tests/ParallelTests.scala
@@ -3,12 +3,14 @@ package cats
 
 import cats.data._
 import cats.tests.CatsSuite
+import org.scalatest.FunSuite
 import cats.laws.discipline.{ApplicativeErrorTests, ParallelTests => ParallelTypeclassTests}
 import cats.laws.discipline.eq._
 import cats.laws.discipline.arbitrary._
 import org.scalacheck.Arbitrary
+import org.typelevel.discipline.scalatest.Discipline
 
-class ParallelTests extends CatsSuite {
+class ParallelTests extends CatsSuite with ApplicativeErrorForEitherTest {
 
 
   test("ParTraversing Either should accumulate errors") {
@@ -68,5 +70,20 @@ class ParallelTests extends CatsSuite {
     checkAll("Parallel[KlesliT[M, ?], Nested[F, Option, ?]]", ParallelTypeclassTests[Kleisli[Either[String, ?], Int, ?], Kleisli[Validated[String, ?], Int, ?], Int].parallel)
   }
 
-  checkAll("ApplicativeError[Either[String, Int]]", ApplicativeErrorTests[Either[String, ?], String].applicativeError[Int, Int, Int])
+
+}
+
+trait ApplicativeErrorForEitherTest extends FunSuite with Discipline {
+  import cats.instances.parallel._
+  import cats.instances.either._
+  import cats.instances.string._
+  import cats.instances.int._
+  import cats.instances.unit._
+  import cats.instances.tuple._
+
+  implicit def eqV[A: Eq,B: Eq]: Eq[Validated[A, B]] = cats.data.Validated.catsDataEqForValidated
+
+
+
+  checkAll("ApplicativeError[Validated[String, Int]]", ApplicativeErrorTests[Validated[String, ?], String].applicativeError[Int, Int, Int])
 }