Order to Ordering conversion

[ceedubs]

In #1646 there's a discussion about how there's a conversion from Order to Ordering but that it won't actually be picked up where an implicit Ordering instance is expected.

It sounds like the general consensus is that we should make it so that after you've imported cats.implicits._ you pick up this functionality.

It may not make a lot of sense to expose this as an implicit in the Order companion object, because it won't be found there during an implicit search for an Ordering instance, and having it there will probably result in ambiguous implicits if someone imports both cats.implicits._ and Order._. However, we may not want to make this incompatible change to cats-kernel. @johnynek do you have thoughts on this?

[ceedubs]

By the way if this is added via cats.implicits._, then #1659 is a relevant change.

[johnynek]

Yeah, adding it to `cats.implicits._` seems like it would be what most users want.

…

On Sat, May 13, 2017 at 05:45 Cody Allen ***@***.***> wrote: By the way if this is added via cats.implicits._, then #1659 <#1659> is a relevant change. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1665 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEJdvWJkBl94FW7Toz3_Swi4IeD0_Nvks5r5dAWgaJpZM4NaG39> .

[edmundnoble]

I'll go ahead tonight and put up the fixed PR.

[edmundnoble]

Up as #1670, #1659 will conflict a teeny tiny bit.

[ceedubs]

Resolved by #1670.