Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NonEmptyVector.last #1832

Closed
durban opened this issue Aug 21, 2017 · 1 comment · Fixed by #1838 or #1974
Closed

NonEmptyVector.last #1832

durban opened this issue Aug 21, 2017 · 1 comment · Fixed by #1838 or #1974
Assignees
@kailuowang

Comments

@durban
Copy link
Contributor

durban commented Aug 21, 2017

NonEmptyVector could have a total last method (unlike Vector). I think it would be useful.

(NonEmptyList could also have this, but I don't know how useful would it be, since it would need to walk the whole list...)
@johnynek
Copy link
Contributor

NonEmptyList does have it:

https://github.com/typelevel/cats/blob/master/core/src/main/scala/cats/data/NonEmptyList.scala#L38

Looks like an oversight on NonEmptyVector. Care to send a PR?

Also double check for other missing methods from one or he other of those?

@durban durban mentioned this issue Aug 21, 2017
Merged
@kailuowang kailuowang mentioned this issue Oct 16, 2017
Merged
12 tasks
@kailuowang kailuowang self-assigned this Oct 16, 2017
kailuowang pushed a commit that referenced this issue Oct 17, 2017
@durban @kailuowang
Sync NEL and NEV methods (fixes #1832) (#1838)
8d94237 
* Sync NEL and NEV methods (fixes #1832)

* Override Traverse#zipWithIndex for NonEmptyVector

* More tests for NonEmptyVector#zipWithIndex

* Add deprecated overload of NonEmptyList#concat

* Try to appease CI

* Deprecating separately
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kailuowang kailuowang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sync NEL and NEV methods (fixes #1832)
Getting ready for RC1 typelevel/cats
3 participants
@johnynek @kailuowang @durban