Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bifold to Bifoldable #2947

Closed
LukaJCB opened this issue Jul 16, 2019 · 2 comments
Closed

Add bifold to Bifoldable #2947

LukaJCB opened this issue Jul 16, 2019 · 2 comments
Labels
good first issue Issues that are easier to take on for first time contributors help wanted

Comments

@LukaJCB
Copy link
Member

LukaJCB commented Jul 16, 2019

Something like this:

def bifold[F[_, _]: Bifoldable, A: Monoid, B: Monoid](fab: F[A, B]): (A, B) =
  bifoldMap(fab)(a => (a, Monoid[B].empty))(b => (Monoid[A].empty, b))
@LukaJCB LukaJCB added good first issue Issues that are easier to take on for first time contributors help wanted labels Jul 16, 2019
takayahilton added a commit to takayahilton/cats that referenced this issue Jul 25, 2019
@takayahilton
Add bifold to Bifoldable close typelevel#2947.
1c335d4
@Twizty
Copy link
Contributor

Twizty commented Sep 27, 2019

Hi, is it still wanted? I'd like to implement that. I guess the previous attempt is abandoned.

Twizty added a commit to Twizty/cats that referenced this issue Sep 27, 2019
@Twizty
typelevel#2947 Added bifold to Bifoldable typeclass
b9c5b3e
Twizty added a commit to Twizty/cats that referenced this issue Sep 27, 2019
@Twizty
typelevel#2947 Formatted
e9ca028
@Twizty Twizty mentioned this issue Sep 27, 2019
Merged
travisbrown pushed a commit to Twizty/cats that referenced this issue Nov 5, 2019
@Twizty @travisbrown
typelevel#2947 Added bifold to Bifoldable typeclass
9df254b
travisbrown pushed a commit to Twizty/cats that referenced this issue Nov 5, 2019
@Twizty @travisbrown
typelevel#2947 Formatted
9f53565
LukaJCB pushed a commit that referenced this issue Nov 5, 2019
@Twizty @LukaJCB
#2947 Added bifold to Bifoldable typeclass (#3088)
5ad3c40 
* #2947 Added bifold to Bifoldable typeclass

* #2947 Formatted

* address Luka's feedback

* reformat
@travisbrown
Copy link
Contributor

This is closed in #3088.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are easier to take on for first time contributors help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@travisbrown @Twizty @LukaJCB