Skip to content

Potential trait encoding binary compatibility issues #3719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
larsrh opened this issue Dec 19, 2020 · 1 comment · Fixed by #4204
Closed

Potential trait encoding binary compatibility issues #3719

larsrh opened this issue Dec 19, 2020 · 1 comment · Fixed by #4204

Comments

@larsrh
Copy link
Contributor

larsrh commented Dec 19, 2020

Since #3596, MiMa recognizes more potential binary compatibility issues. The cause for those is documented in that PR.

Eventually we should try to fix these problems, possibly in Cats 2.4.0.

exclude[NewMixinForwarderProblem]("cats.kernel.Band#mcI#sp.combineN"),
exclude[NewMixinForwarderProblem]("cats.kernel.Band#mcD#sp.combineN"),
exclude[NewMixinForwarderProblem]("cats.kernel.Band#mcJ#sp.combineN"),
exclude[NewMixinForwarderProblem]("cats.kernel.Band.combineN"),
exclude[NewMixinForwarderProblem]("cats.kernel.Band#mcF#sp.combineN"),
exclude[NewMixinForwarderProblem]("cats.data.Tuple2KApply.product"),
exclude[NewMixinForwarderProblem]("cats.InvariantInstances0.catsApplicativeForArrow")
@armanbilge
Copy link
Member

armanbilge commented May 7, 2022

With modern cats/mima only exclude[NewMixinForwarderProblem]("cats.kernel.Band.combineN") is still relevant. Unfortunately I don't think it's possible to fix bincompat here without breaking override semantics, see #4204 (comment).

Edit: nope, spoke to soon. The encoding changed between 2.12 and 2.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants