Skip to content

Update sbt-mima-plugin to 0.8.0 #3596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

scala-steward
Copy link
Contributor

Updates com.typesafe:sbt-mima-plugin from 0.7.0 to 0.8.0.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.typesafe", artifactId = "sbt-mima-plugin" } ]

labels: sbt-plugin-update, semver-minor

@fthomas
Copy link
Member

fthomas commented Sep 8, 2020

The MiMa checks for 2.12 and 2.13 are failing now.

2.12:

[error] Cats core: Failed binary compatibility check against org.typelevel:cats-core_2.12:1.0.1! Found 1 potential problems (filtered 291)
[error]  * in current version, classes mixing cats.data.Tuple2KApply need be recompiled to wire to the new static mixin forwarder method all super calls to method product(cats.data.Tuple2K,cats.data.Tuple2K)cats.data.Tuple2K
[error]    filter with: ProblemFilters.exclude[NewMixinForwarderProblem]("cats.data.Tuple2KApply.product")

2.13:

[error] Cats core: Failed binary compatibility check against org.typelevel:cats-core_2.13:2.0.0! Found 1 potential problems (filtered 49)
[error]  * in current version, classes mixing cats.data.Tuple2KApply need be recompiled to wire to the new static mixin forwarder method all super calls to method product(cats.data.Tuple2K,cats.data.Tuple2K)cats.data.Tuple2K
[error]    filter with: ProblemFilters.exclude[NewMixinForwarderProblem]("cats.data.Tuple2KApply.product")

@johnynek
Copy link
Contributor

I think these two problems are minor enough to add an exception, but if we could possibly fix it in 2.2.1, I think it would be preferable (just because human judgements of what is a safe break are sometimes wrong).

@djspiewak
Copy link
Member

Static forwarders aren't used by Scala code anyway, and Tuple2K is literally useless from Java, so… :-)

@smarter
Copy link
Contributor

smarter commented Sep 18, 2020

Static forwarders aren't used by Scala code anyway

This isn't about the static forwarders in objects, it's about a weird detail of trait encoding and it does impact Scala code: scala/bug#12137

@djspiewak
Copy link
Member

Owwwwwwwwwwww

@fthomas
Copy link
Member

fthomas commented Oct 19, 2020

Superseded by #3641.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants